[canalyst] get CANalyst-II working through init, once more#617
Merged
christiansandberg merged 6 commits intohardbyte:developfrom Jun 12, 2019
Merged
[canalyst] get CANalyst-II working through init, once more#617christiansandberg merged 6 commits intohardbyte:developfrom
christiansandberg merged 6 commits intohardbyte:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #617 +/- ##
======================================
Coverage 64% 64%
======================================
Files 63 63
Lines 5607 5607
======================================
Hits 3589 3589
Misses 2018 2018 |
christiansandberg
approved these changes
Jun 11, 2019
Merged
hardbyte
pushed a commit
that referenced
this pull request
Dec 28, 2019
Pass kwargs through to BusABC's initializer. Doesn't backport changing baud to bitrate to avoid changing the API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these two changes, I was able to get
can-loggerto start on either one of my CANalyzer-II without a~/.canrc. Without them, I just saw a bunch of errors.Prior to this change, I'd get stuff like:
TypeError: __init__() got an unexpected keyword argument 'single_handle'Failed tests hold steady at 2.